This repository was archived by the owner on Feb 1, 2026. It is now read-only.
Merged
Conversation
We test up to PHP 7.4 for now
Member
|
Probably better to target https://github.com/pear/Image_Color2 but oh well we have merged newer content to this repo. |
CloCkWeRX
approved these changes
Nov 26, 2024
Contributor
Author
I worked on this repo because pear/Image_Canvas uses it (and my project uses Image_Canvas). It was done at the beginning of 2024 (there was some exchange on the ML around that). I can have a look at pear/Image_Color2 too (but not right now). |
Contributor
Author
|
Ah, thanks for solving the conflicts. This extra line is weird (probably a mistake on my side), I think we should remove it. |
CloCkWeRX
reviewed
Nov 26, 2024
Contributor
Author
|
Thanks for your work (I was a bit busy today) and merging this. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports the code to PHP 8: it now runs from PHP 5.6 to PHP 8.4.
The main changes to the code are:
This PR is based on the branch used for PR #3 (so this one must be merged first and I must rebase).